support Kunlun2 #34459
Merged
support Kunlun2 #34459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
taixiurong
reviewed
Jul 29, 2021
| XPUDeviceContext::XPUDeviceContext() { | ||
| context_ = xpu::create_context(); | ||
| xpu_version_ = get_xpu_version(place_.device); | ||
| } | ||
|
|
There was a problem hiding this comment.
前面的文件是不是需要获取 L3的大小的接口，在下面可以传入L3的大小，根据卡的大小来设置？
There was a problem hiding this comment.
runtime有提供了这个接口xpu_get_device_attr，根据需要后面可以添加。
| {"batch_norm", XPUKernelSet({pOpKernelType(vartype::FP32, XPUPlace())})}, | ||
| {"batch_norm_grad", | ||
| XPUKernelSet({pOpKernelType(vartype::FP32, XPUPlace())})}, | ||
| {"cast", XPUKernelSet({pOpKernelType(vartype::FP32, XPUPlace())})}, |
There was a problem hiding this comment.
这个data_type是怎么确定的，kl1的cast只支持fp32吗
There was a problem hiding this comment.
这个type data_type是REGISTER_OP_KERNEL时指定的type，应该是输入的类型。
KL1目前支持FP32， int32， int64，这边漏加了，下个PR我不上去。
There was a problem hiding this comment.
嗯，应该还有挺多op的type需要补的，比如one_hot
There was a problem hiding this comment.
ok，这个我下个PR再核验一下
fuyinno4
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Support Kunlun2.