[NPU] refine nan check #34508
Merged
[NPU] refine nan check #34508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
approved these changes
Aug 2, 2021
|
|
||
| return found_inf_data; | ||
| if (std::isnan(static_cast<float>(vec[0]))) { |
There was a problem hiding this comment.
LOG(WARNING) << "deteced Nan";
| return found_inf_data; | ||
| if (std::isnan(static_cast<float>(vec[0]))) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
if (std::isinf(static_cast<float>(vec[0]))){
LOG(WARNING) << "deteced inf";
}
| } | ||
| const auto& runner_mean = NpuOpRunner("ReduceMeanD", {*in}, {mean}, | ||
| {{"axes", axes}, {"keep_dims", false}}); |
There was a problem hiding this comment.
我们不用 "Div" + "ReduceSumD"?
gongweibao
added a commit
that referenced
this pull request
Aug 2, 2021
This reverts commit 393a0b1.
gongweibao
added a commit
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
CheckNumerics is very slow, we first call ResuceMean and then check one float variable.