Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hybrid] remove the using of global ring in hybrid parallel #34525

Merged
merged 10 commits into from
Aug 3, 2021

Conversation

wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Aug 1, 2021

PR types

Others

PR changes

Others

Describe

1、Refine some code of c_comm_init_op.
2、c_gen_{nccl,bkcl,hccl}_id_op add Attr(ring_id) to distinguish different group's comm_id broadcast.
3、Remove the using of global ring in hybrid parallel.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wangxicoding wangxicoding changed the title stop using global ring in hybrid parallel [hybrid] remove the using of global ring in hybrid parallel Aug 3, 2021
Copy link
Contributor

@Baibaifan Baibaifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for NPU

Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit 56b7ebb into PaddlePaddle:develop Aug 3, 2021
@wangxicoding wangxicoding deleted the refine_gen_comm_id branch August 3, 2021 12:26
Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants