support more dim for mul op npu #34546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pangyoki
reviewed
Aug 2, 2021
| sum_2 = paddle.add(c, d) | ||
| result = paddle.fluid.layers.mul(sum_1, sum_2) | ||
|
|
||
| fc_1 = fluid.layers.fc(input=result, size=8) |
There was a problem hiding this comment.
fc操作移到mul操作之前，才能检测出mul_grad计算反向时结果是否正确。
因为只有fc中有参数，mul在fc前面时，即使mul_grad计算错误，参数更新也不会有问题。
zhangting2020
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
在NPU环境下跑PaddleHub的resnet50_vd_animals模型的时候，会报错说mul算子不支持某些类型的输入，报dim不支持。具体是：
所以修改了代码，把原先代码逻辑中dims的
x->dims().size() == 3的情况，进行了扩大，改成了>=3，这样那个跑不过的模型就能跑过了。单测可以跑过，并且确定在执行单测的时候，mul_op的状态不是missing。