[NPU] Support npu kernel for assign_value op #34568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zhwesky2010
reviewed
Aug 3, 2021
qili93
requested changes
Aug 3, 2021
python/paddle/fluid/tests/unittests/npu/test_assign_value_op_npu.py
Outdated
Show resolved
Hide resolved
| a=[False, True], size=(2, 5)).astype(numpy.bool) | ||
| self.attrs["bool_values"] = [bool(v) for v in self.value.flat] | ||
|
|
||
|
|
There was a problem hiding this comment.
建议参考test_assign_value_op.py把里面4个TestAssignApi相关的单测也加上，相应的修改NPUPlace。
There was a problem hiding this comment.
你好，感谢review。已将相应的TestAssignApi类加上并改成NPUPlace，单测结果如下图。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
When inputs' dtype is bool, there is no corresponding TensorFromVector template function for vector, so only TensorFromArray can be used, but it didn't consider npu condition before.
ctest result and op running environment
