Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to disable paddle signal handler #34577

Merged
merged 4 commits into from
Aug 18, 2021

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Aug 3, 2021

PR types

New features

PR changes

APIs

Describe

Paddle used google::InstallFaultSignalHandler to handle selected system signals,
mainly for debugging and bug report purposes.

However, this can be conflicted with other python packages whoever captures similar signals.
Such python package involves tvm and more

To resolve this issue, we support a function to disable signal handler

Note that Paddle does not register signal handlers on Windows platform. So this function is only needed on Linux/Unix.

CN doc: PaddlePaddle/docs#3700
CN preview:
image

EN preview:
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 3, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 3, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@JiabinYang
Copy link
Contributor

Add API doc and design doc

Paddle used google::InstallFaultSignalHandler to handle selected system signals,
mainly for debugging and bug report purposes.

However, this can be conflicted with other python packages whoever captures similar signals.
Such python package involves tvm and more

To resolve this issue, we support a function to disable signal handler
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanxianghit
Copy link
Contributor

除了api调用,是否可以通过环境变量来进行设置?

Copy link
Member

@ZeyuChen ZeyuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit dd533dd into PaddlePaddle:develop Aug 18, 2021
JiabinYang pushed a commit to PaddlePaddle/docs that referenced this pull request Aug 27, 2021
* Add CN doc for disable_signal_handler

PR: PaddlePaddle/Paddle#34577

* Add detailed messages to cn_doc
jim19930609 added a commit to jim19930609/Paddle that referenced this pull request Sep 1, 2021
* Add function to disable paddle signal handler

Paddle used google::InstallFaultSignalHandler to handle selected system signals,
mainly for debugging and bug report purposes.

However, this can be conflicted with other python packages whoever captures similar signals.
Such python package involves tvm and more

To resolve this issue, we support a function to disable signal handler

* Remove signal test from WIN32 platform

* Remove redundant return from disable_signal_handler() function

* Add detailed messages to en_doc
jim19930609 added a commit to jim19930609/docs that referenced this pull request Sep 1, 2021
* Add CN doc for disable_signal_handler

PR: PaddlePaddle/Paddle#34577

* Add detailed messages to cn_doc
XiaoguangHu01 pushed a commit that referenced this pull request Sep 4, 2021
* Add function to disable paddle signal handler

Paddle used google::InstallFaultSignalHandler to handle selected system signals,
mainly for debugging and bug report purposes.

However, this can be conflicted with other python packages whoever captures similar signals.
Such python package involves tvm and more

To resolve this issue, we support a function to disable signal handler

* Remove signal test from WIN32 platform

* Remove redundant return from disable_signal_handler() function

* Add detailed messages to en_doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants