Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dygraph has_grad thread safety bug #34649

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Aug 5, 2021

PR types

Bug fixes

PR changes

Others

Describe

Tracer::has_grad_是进程单例,多线程调用@no_grad会导致反向trace出错。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 5, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 68377b4 into PaddlePaddle:develop Aug 5, 2021
@sneaxiy sneaxiy deleted the fix_dygraph_has_grad branch August 5, 2021 14:50
@sneaxiy sneaxiy changed the title fix dygraph has_grad fix dygraph has_grad thread safety bug Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants