Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Code Coverage for Paddle refactor code #3489

Closed
wants to merge 26 commits into from

Conversation

gangliao
Copy link
Contributor

@gangliao gangliao commented Aug 15, 2017

fix #3298

  • Add code coverage for PaddlePaddle refactorization code
  • generate coveralls report
  • Add git commit into JSON to bind coveralls with GitHub

image

https://coveralls.io/github/PaddlePaddle/Paddle

@@ -15,7 +15,7 @@
package pserver

// #cgo CFLAGS: -I ../../
// #cgo LDFLAGS: ${SRCDIR}/client/c/libpaddle_go_optimizer.a -lstdc++ -lm
// #cgo LDFLAGS: /Users/liaogang/baidu/Paddle/go/pserver/client/c/libpaddle_go_optimizer.a -lstdc++ -lm -g -O0 -fprofile-arcs -ftest-coverage
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ignore this modification, because go/pserver/.gitignore is added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use git rm PATH_TO_FILE to remove it from git.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 539c86b on gangliao:coveralls into ** on PaddlePaddle:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8ceee0f on gangliao:coveralls into ** on PaddlePaddle:develop**.

Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except optimizer.go should be removed from git.

@@ -15,7 +15,7 @@
package pserver

// #cgo CFLAGS: -I ../../
// #cgo LDFLAGS: ${SRCDIR}/client/c/libpaddle_go_optimizer.a -lstdc++ -lm
Copy link
Contributor

@helinwang helinwang Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming optimizer.go to optimizer.go.in will break building from Go without cmake. Do we really need this?

Copy link
Contributor Author

@gangliao gangliao Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can find another way to suppress this later.

@paddle-bot-old
Copy link

Since you haven't replied for a long time, we have closed this issue/pr.
If the problem is not solved or there is a follow-up one, please reopen it at any time and we will continue to follow up.
由于您长期未回复,我们将关闭这个issue/pr。
若问题未解决或有后续问题,请随时重新打开,我们会继续跟进。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopen Code Coverage
4 participants