use param header to save mkldnn format info #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Aug 16, 2017
doc/design/mkldnn/README.MD
Outdated
| @@ -101,6 +101,7 @@ if use_mkldnn | |||
| 5. 在**Argument**里添加两个`MkldnnMatrixPtr`，取名为`mkldnnValue`和`mkldnnGrad`，用于存放`MkldnnLayer`会用到的memory buffer。 并且添加函数cvt(会修改为一个更加合适的函数名)，用于处理"CPU device"和"MKL-DNN device"之间memory的相互转化。 | |||
| 6. 在父类`Layer`中的`getOutput`函数中添加一段逻辑，用于判断`deviceId`，并针对device在MKL-DNN和CPU之间不统一的情况，做一个前期转换。 也就是调用`Argument`的cvt函数把output统一到需要的device上。 | |||
| 7. 在原来的`FLAGS`中添加一个`use_mkldnn`的flag，用于选择是否使用MKL-DNN的相关功能。 | |||
| 8. 关于MKLDNN参数的保存。由于MKLDNN参数的格式与PaddlePaddle原有的格式存在不一样的情况，所以需要在保存参数时同时保存该格式信息。目前准备扩展`Header`里面的`int32_t version; // = 0, file format version`信息。这个`version`值，不管是在v1还是在v2里面，一直保存的是0。所以可以充分利用这个信息，定义一个枚举处理所有MKLDNN的参数格式，`MKLDNNLayer`就可以知道得到的参数是哪种格式的了。只不过目前v2里面是写的固定值0，而不是保存的`Header`本身，这一点相信v2未来应该会优化的。 | |||
There was a problem hiding this comment.
- 准备扩展struct Header里面的
int32_t version信息。
- 需要加上链接，说明是在哪个代码里面的？或者贴讨论的issue号。不然还是看不懂说的是哪里。
- 里面的注释去掉，这个注释不合理，后面要改掉。
- “只不过目前v2里面是写的固定值0，而不是保存的
Header本身，这一点相信v2未来应该会优化的。”这句可以去掉，为了mkldnn的格式，这块也要马上做修改，不能写死。
There was a problem hiding this comment.
Thanks, done.
另外我想问下，我可以把code里面的version名字改为format吗？现在感觉这个名字更加贴切。
luotao1
reviewed
Aug 16, 2017
luotao1
approved these changes
Aug 16, 2017
|
好的~
另外，我备注下，需要加一个task， 我们要让v2不能仅仅只保存version为0的值。 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update doc