add cumprod op #35185
Merged
add cumprod op #35185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
✅ This PR's description meets the template requirements! |
|
Thanks for your contribution! |
This reverts commit c96cf6d.
sneaxiy
reviewed
Sep 2, 2021
sneaxiy
reviewed
Sep 6, 2021
| ['X'], | ||
| 'Out', | ||
| user_defined_grads=[self.grad_x], | ||
| user_defined_grad_outputs=[self.grad_out]) |
There was a problem hiding this comment.
I prefer to using user_defined_grads and user_defined_grad_outputs only in complex cases.
sneaxiy
requested review from
Superjomn,
raindrops2sea,
XieYunshen,
lanxianghit and
jzhang533
sneaxiy
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM for codes. But not quite sure on the UT timeout settings. Please have a look @XieYunshen .
XieYunshen
approved these changes
Sep 9, 2021
TCChenlong
reviewed
Sep 9, 2021
TCChenlong
approved these changes
Sep 9, 2021
raindrops2sea
approved these changes
Sep 10, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* add test_cumprod_op * Revert "add test_cumprod_op" This reverts commit c96cf6d. * recommit * add error message * test input(x) initialize * test use cpu * update test code * add test type * add test case * solve ci problem * add complex case test * add complex case test * fix review problem * fix conflict * fix some docs * change test case * change test case * fix review problems again * fix docs * fix inclusivescan bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add cumprod op
中文文档PR链接：PaddlePaddle/docs#3865