Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] Disable cache matmul v1 & refactoring #35331

Merged
merged 12 commits into from
Sep 7, 2021

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented Aug 31, 2021

PR types

Others

PR changes

OPs

Describe

This PR disabled caching of Matmul oneDNN objects whereas leaving it to oneDNN to use its own caching mechanism

@jczaja jczaja added the Intel label Aug 31, 2021
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

- Fix

- compilation fix

- another compilation fix

- refactoring
@jakpiase jakpiase self-requested a review September 3, 2021 13:27
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja closed this Sep 3, 2021
@jczaja jczaja reopened this Sep 3, 2021
Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit e9ae8dd into PaddlePaddle:develop Sep 7, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
* - refactoring progressing

- Fix

- compilation fix

- another compilation fix

- refactoring

* - fix

* - compilation fix

* - compilation fix

* - missing set_format

* - compilation fix

* - reverted setting memeory format

* - Brought back format

* - Fix

* - fixes after review

* CI rerun

* CI rerun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants