Add grad grad for AvgPool2D #35388
Merged
Add grad grad for AvgPool2D #35388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
LielinJiang
reviewed
Sep 2, 2021
| @@ -381,5 +381,29 @@ def test_grad(self): | |||
| self.func(p) | |||
|
|
|||
|
|
|||
| class TestAvgPool2DDoubleGradCheck(unittest.TestCase): | |||
There was a problem hiding this comment.
建议多加一些单测，可以参考下conv的二次梯度单测。
LielinJiang
approved these changes
Sep 2, 2021
dyning
approved these changes
Sep 5, 2021
qingqing01
reviewed
Sep 6, 2021
| using framework::SingleGradOpMaker<T>::SingleGradOpMaker; | ||
|
|
||
| protected: | ||
| void Apply(GradOpPtr<T> grad_op) const override { |
There was a problem hiding this comment.
可以在ProtoMaker里直接复用forward op，下面就不用实现PoolGradGradKernel了。 参考
Paddle/paddle/fluid/operators/transpose_op.cc
Line 293 in 13bbb6b
qingqing01
approved these changes
Sep 6, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* add pool2d grad grad * dbg * add unittest * update format * add more unittests * dbg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add grad grad for AvgPool2D