Add DPADDLE_WITH_CUDA for GCC #35448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Sep 6, 2021
| @@ -433,6 +433,9 @@ def unix_custom_single_compiler(obj, src, ext, cc_args, extra_postargs, | |||
| # See https://stackoverflow.com/questions/34571583/understanding-gcc-5s-glibcxx-use-cxx11-abi-or-the-new-abi | |||
| add_compile_flag(['-D_GLIBCXX_USE_CXX11_ABI=1'], cflags) | |||
|
|
|||
| if not is_cuda_file(src): | |||
There was a problem hiding this comment.
- windows需要加判断吗
- 如果用户仅编译cc文件，也会添加这个宏吗
There was a problem hiding this comment.
windows也添加了。这里只会对Extension中联合编译了 .cu 文件时，才会对编译.cc文件额外添加PADDLE_WITH_CUDA
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* Add DPADDLE_WITH_CUDA for GCC * polish code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add DPADDLE_WITH_CUDA for GCC