Add new API "eigvals" in linalg #35720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add-linalg-eigvals-API
… add-linalg-eigvals-API
|
Thanks for your contribution! |
zhiqiu
reviewed
Sep 14, 2021
| .. code-block:: python | ||
|
|
||
| import paddle | ||
|
|
There was a problem hiding this comment.
Add paddle.seed(x) to fix output.
Comment on lines
35
to
50
| def np_eigvals_grad(a, out_grad): | ||
| l, v = np.linalg.eig(a) | ||
| print("l:") | ||
| print(l) | ||
| print("v:") | ||
| print(v) | ||
| vh = v.conj().T | ||
| print("vh:") | ||
| print(vh) | ||
| print("out_grad:") | ||
| print(out_grad) | ||
| a_grad = np.linalg.solve(vh, np.diagflat(out_grad, 0) * vh) | ||
| print("a_grad") | ||
| print(a_grad) | ||
|
|
||
| return a_grad.astype(a.dtype) |
There was a problem hiding this comment.
It has been commented out.
paddle/fluid/operators/eigvals_op.h
Outdated
| template <typename T> | ||
| using EigenVectorStd = Eigen::Matrix<StdCType<T>, Eigen::Dynamic, 1>; | ||
|
|
||
| static void SpiltBatchSquareMatrix(const Tensor *input, |
There was a problem hiding this comment.
Better use const& for input
zhiqiu
approved these changes
Sep 17, 2021
XieYunshen
approved these changes
Sep 17, 2021
TCChenlong
approved these changes
Sep 17, 2021
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* Add linalg.eigvals API * pre-commit check * Adjust code style * Fix conflict * Improve code style * Modify the test code to ignore testing CUDA kernel * Sort ouput data before checking in test code * Set timeout value for UT * Improve API example code to pass CI * Fix bug for None fetch_list in Windows * Delete grad Op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add a new API: linalg.eigvals
The corresponding PR for CN docs：PaddlePaddle/docs#3875
NOTE