Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PaddlePaddle Hackathon] add ResNeXt #36070

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Sep 24, 2021

PR types

New features

PR changes

APIs

Describe

status: Pending Review

Performance

AiStudio 测试详情:https://aistudio.baidu.com/aistudio/projectdetail/2422677?contributionType=1
基准参考:https://github.com/PaddlePaddle/PaddleClas/blob/release/2.2/docs/en/ImageNet_models_en.md

Model Top-1 Top-5
ResNeXt50_32x4d 0.7772(-0.0003) 0.9378(-0.0005)
ResNeXt50_64x4d 0.7841(-0.0002) 0.9415(+0.0002)
ResNeXt101_32x4d 0.7874(+0.0009) 0.9417(-0.0002)
ResNeXt101_64x4d 0.7935(+0.01) 0.9455(+0.0003)
ResNeXt152_32x4d 0.7894(-0.0004) 0.9434(+0.0001)
ResNeXt152_64x4d 0.7947(-0.0004) 0.9466(-0.0005)

括号中为以 PaddleClas 性能基准为参考的偏差值

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo marked this pull request as ready for review September 24, 2021 17:34
@SigureMo SigureMo changed the title add resnext [PaddlePaddle Hackathon] add ResNeXt Sep 26, 2021
@SigureMo
Copy link
Member Author

@LielinJiang 我试了所有我所迁移的模型,直接删除 name 可以直接加载预训练权重(无任何warning),那是不是就可以不用修改clas权重的名字了呀?

另外我和队友还做了一下基准测试,请问像这样是可以的嘛(见上面)?

@LielinJiang
Copy link
Contributor

@LielinJiang 我试了所有我所迁移的模型,直接删除 name 可以直接加载预训练权重(无任何warning),那是不是就可以不用修改clas权重的名字了呀?

另外我和队友还做了一下基准测试,请问像这样是可以的嘛(见上面)?

那麻烦在统一程序中,实例化两次看看是否会报错,如果不会报错,那就没问题了:

import paddle
resnext1 = paddle.vision.ResNext()
resnext2 = paddle.vision.ResNext()

@SigureMo
Copy link
Member Author

那麻烦在统一程序中,实例化两次看看是否会报错,如果不会报错,那就没问题了:

好哒好哒~刚刚在基准测试所用 Notebook 里增加了多次实例化的测试,是可以直接跑通的

更新后的 notebook:https://aistudio.baidu.com/aistudio/projectdetail/2422677?contributionType=1

image

请问这样是不是就可以进行提交了呀?

@LielinJiang
Copy link
Contributor

那麻烦在统一程序中,实例化两次看看是否会报错,如果不会报错,那就没问题了:

好哒好哒~刚刚在基准测试所用 Notebook 里增加了多次实例化的测试,是可以直接跑通的

更新后的 notebook:https://aistudio.baidu.com/aistudio/projectdetail/2422677?contributionType=1

image

请问这样是不是就可以进行提交了呀?

可以的辛苦了

@SigureMo
Copy link
Member Author

好的感谢~~~

"""

def __init__(self,
layers=50,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改~

LielinJiang
LielinJiang previously approved these changes Oct 8, 2021
@SigureMo
Copy link
Member Author

SigureMo commented Oct 8, 2021

@LielinJiang 十分抱歉,刚刚在修改其他模型时候发现 ResNeXt 出了点问题,之后又重新 commit 修复了这个问题,这导致之前的 review 被视为 dismiss 了( •̥́ ˍ •̀ू ),可以重新 review 一下嘛?

此外,以下三个模型也均已完成修改,均增加了 with_pool 参数~~~

* add resnext model
* add zh docs
* add unittest
* test performance

Co-authored-by: Ainavo <ainavo@163.com>
Co-authored-by: pithygit <pyg20200403@163.com>
@SigureMo
Copy link
Member Author

已经解决冲突,CI 也已通过(除去需要 Approve 的和非 Required 的),可以麻烦再次 Review 一下嘛?

@LielinJiang @TCChenlong @XiaoguangHu01

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LielinJiang LielinJiang merged commit 277c9a5 into PaddlePaddle:develop Oct 15, 2021
@SigureMo SigureMo deleted the resnext branch October 17, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants