[NPU] fix elementwise_mul to support broadcast, test=develop #36258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
reviewed
Oct 11, 2021
|
|
||
|
|
||
| # TODO(qili93): Paddle enformce not met: | ||
| # dimension mismatch at elementwise_op_function.h:240 |
There was a problem hiding this comment.
assertRaises can check exception
There was a problem hiding this comment.
Fixed by adding axis support.
In paddle 2.0, axis is not supported as parameter in multiply api, while axis is able to set to non -1 in paddle.fluid.layers.elementwise_mul. Fix elementwise_mul_op_npu.cc to support axis = -1. The previous error is caused by input is broadcast case while axis is always set to -1 in 2.0 api.
zhangting2020
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Fix elementwise_mul to support broadcast.