[Cherry-pick]FFT function enhancements and bugfixes #36537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update fft api path * add sample code for ihfft2 Co-authored-by: chenfeiyu <chenfeiyu@baidu.com>
fix: `-1` is used when fft's axis is `0`
|
Thanks for your contribution! |
…uffix move signal apis
cxxly
changed the title
* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py
* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos
* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos * Add LRUCache for fft plans
* move signal apis * move fft.py and signal.py to paddle/, fix typos * fix relative imports from fft.py and signal.py * fix typos * WIP: add cache * delete move constructor and operator= for CuFFTHandle and FFTConfig * remove log from CuFFTHandle and FFTConfig * add lrucache for fft rocm backend * disable LRUCache when CUFFT_VERSION >= 10200 * disbale copy and move for hipFFTHandle; format code Co-authored-by: Xiaoxu Chen <chenxx_id@163.com>
wadefelix
reviewed
Oct 27, 2021
| @@ -32,4 +32,4 @@ fi | |||
| protobuf/bin/protoc -I../../paddle/fluid/platform/ --python_out . ../../paddle/fluid/platform/external_error.proto | |||
|
|
|||
| python3.7 spider.py | |||
| tar czvf externalErrorMsg.tar.gz externalErrorMsg.pb | |||
| tar czvf externalErrorMsg_$(date +'%Y%m%d').tar.gz externalErrorMsg.pb | |||
There was a problem hiding this comment.
这个也是延续之前的做法，此前就是用压缩包的，可能是和其他依赖文件一样的习惯。
事实上对于小文件，甚至可以直接包含在 repo 里面。
|
|
||
| ``` | ||
| set(URL "https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz" CACHE STRING "" FORCE) | ||
| file_download_and_uncompress(${URL} "externalError" MD5 a712a49384e77ca216ad866712f7cafa) |
There was a problem hiding this comment.
我建议bos上提供一个 https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz.md5sum 文件用来校验。
There was a problem hiding this comment.
这个可以在后期来一波全面的修改，因为 cmake 文件里面几乎都是把 MD5 写在了文件里。我们也遵循了习惯。
| set(URL "https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg.tar.gz" CACHE STRING "" FORCE) | ||
| file_download_and_uncompress(${URL} "externalError" MD5 061f3b7895aadcbe2c3ed592590f8b10) # download file externalErrorMsg.tar.gz | ||
| set(URL "https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz" CACHE STRING "" FORCE) | ||
| file_download_and_uncompress(${URL} "externalError" MD5 a712a49384e77ca216ad866712f7cafa) # download file externalErrorMsg.tar.gz |
There was a problem hiding this comment.
建议提供一个 https://paddlepaddledeps.bj.bcebos.com/externalErrorMsg_20210928.tar.gz.md5sum 文件以供校验。
这是比较符合软件下载的常见的一种校验值提供方式。
There was a problem hiding this comment.
我们这里是延续 paddle 之前的做法，md5 都写在了代码里。
如果这是一个好的校验值提供方式，那么后续可以来一波全面的更改。
chenwhql
approved these changes
Oct 27, 2021
raindrops2sea
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
cherry-pick of following PRs: