Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fleet_executor] Add retry to the message bus's send. Use unique_lock instead of calling lock(). #37087

Merged
merged 2 commits into from
Nov 10, 2021
Merged

[fleet_executor] Add retry to the message bus's send. Use unique_lock instead of calling lock(). #37087

merged 2 commits into from
Nov 10, 2021

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Nov 10, 2021

PR types

Others

PR changes

Others

Describe

Add retry to the message bus's send. Use unique_lock instead of calling lock().
Lower the level of send fail's vlog to avoid too many log when retry.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wangxicoding
wangxicoding approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeixLiu FeixLiu merged commit f5caf9c into PaddlePaddle:develop Nov 10, 2021
@FeixLiu FeixLiu deleted the message_bus_update branch November 12, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangxicoding wangxicoding wangxicoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FeixLiu @wangxicoding