[FleetExecutor]Add interceptor message handle #37093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
changed the title
FeixLiu
reviewed
Nov 10, 2021
| @@ -32,13 +33,21 @@ namespace distributed { | |||
| class TaskNode; | |||
|
|
|||
| class Interceptor { | |||
| public: | |||
| using InterceptorHandle = std::function<void(const InterceptorMessage&)>; | |||
There was a problem hiding this comment.
InterceptorMessageHandle? 🤣
LiYuRio
reviewed
Nov 10, 2021
| @@ -49,6 +58,8 @@ class Interceptor { | |||
| bool EnqueueRemoteInterceptorMessage( | |||
| const InterceptorMessage& interceptor_message); | |||
|
|
|||
| void Send(int64_t dst_id, std::unique_ptr<InterceptorMessage> msg); | |||
There was a problem hiding this comment.
可能需要改写message，没有用const引用，然后send出去应该就交给message bus管理了，就先用了unique_ptr，理论上用shared_ptr或者直接一个指针也行。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Add interceptor message handle and send function