Dependence analysis #37231
Merged
Dependence analysis #37231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Aurelius84
reviewed
Nov 16, 2021
| void InterpreterCore::BuildOperatorDependences() { | ||
| // set the dependecy_count_ and Call Schedule | ||
| // refer to http://agroup.baidu.com/share/md/92946214aa4c4785a2cc4c1f361a023c | ||
| // for pesudo code |
There was a problem hiding this comment.
不要在代码里添加百度内部的文档链接，可以参看graph.h那样，在这里添加整体的方案思路描述
| std::set<int> remove_duplicate; | ||
|
|
||
| // reserve | ||
| for (size_t op = 0; op < vec_instruction_.size(); ++op) { |
There was a problem hiding this comment.
Suggested change
| for (size_t op = 0; op < vec_instruction_.size(); ++op) { | |
| for (size_t i = 0; i < op_nums; ++i) { |
| } | ||
| dependecy_count_.resize(op_nums); | ||
|
|
||
| for (size_t op = 0; op < vec_instruction_.size(); ++op) { |
There was a problem hiding this comment.
Suggested change
| for (size_t op = 0; op < vec_instruction_.size(); ++op) { | |
| for (size_t op_idx = 0; op_idx < op_nums; ++op_idx) { |
| } | ||
| } | ||
|
|
||
| auto op2downstream = get_downstream_map(op2dependences); |
zhiqiu
reviewed
Nov 16, 2021
| @@ -289,7 +282,7 @@ void InterpreterCore::BuildSkipShareLoDInfo() { | |||
| void InterpreterCore::RunInstruction(const Instruction& instr_node) { | |||
| auto* op = instr_node.OpBase(); | |||
| auto place = instr_node.DeviceContext().GetPlace(); | |||
| VLOG(4) << place << " " << op->DebugStringEx(global_scope_); | |||
| VLOG(4) << "Start run" << place << " " << op->DebugStringEx(global_scope_); | |||
There was a problem hiding this comment.
Suggested change
| VLOG(4) << "Start run" << place << " " << op->DebugStringEx(global_scope_); | |
| VLOG(4) << "Start run " << place << " " << op->DebugStringEx(global_scope_); |
| @@ -320,7 +313,7 @@ void InterpreterCore::RunInstruction(const Instruction& instr_node) { | |||
| instr_node.KernelFunc()(*instr_node.InnerExecutionContext().get()); | |||
| } | |||
|
|
|||
| VLOG(3) << place << " " << op->DebugStringEx(global_scope_); | |||
| VLOG(4) << "End run" << place << " " << op->DebugStringEx(global_scope_); | |||
There was a problem hiding this comment.
Suggested change
| VLOG(4) << "End run" << place << " " << op->DebugStringEx(global_scope_); | |
| VLOG(4) << "End run " << place << " " << op->DebugStringEx(global_scope_); |
| @@ -77,6 +77,23 @@ paddle::framework::FetchList InterpreterCore::Run( | |||
| return *(fetch_var->GetMutable<framework::FetchList>()); | |||
| } | |||
|
|
|||
| void InterpreterCore::BuildOperatorDependences() { | |||
| // analysis the dependences between ops, set the dependecy_count_ and Call | |||
wanghuancoder
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
这个PR修复了新执行器的依赖分析算法。之前的新执行器对于多次write和read write的依赖关系分析有漏洞，现在的PR重写了Op依赖分析逻辑。具体算法和问题来源可以参考文档： http://agroup.baidu.com/share/md/839f7c5eb0d543cc9245084d9eecab22 [执行器控制流静态分析存在的一类问题【已定位】] 。上面列举了分析算法伪代码和实现逻辑。应该比代码容易理解。