Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quantization of condition block #37498

Merged
merged 11 commits into from
Dec 10, 2021

Conversation

yghstill
Copy link
Contributor

PR types

Function optimization

PR changes

APIs

Describe

Support sub graph quant in PostTrainingQuantization API.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wanghaoshuang
wanghaoshuang previously approved these changes Nov 25, 2021
Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遗留两个问题:

  1. PaddleLite提出:子图中的Persistable变量(量化的fakexxxx节点的inscale等参数)没有在LoadCombinedParamsPb时候读取,在LoadCombinedParamsPb函数中加上对所有子图遍历可以trick掉。 这个问题需要和PaddleLite确认如果解决更合理,并在后续PR中修复。
  2. op_device设置为空,需要确认是否有负面影响。

@yghstill yghstill changed the title Support sub graph quant-post Support quantization of condition block Nov 25, 2021
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add UT!

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 3, 2021

Sorry to inform you that 4e70480's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@yghstill
Copy link
Contributor Author

yghstill commented Dec 5, 2021

遗留两个问题:

  1. PaddleLite提出:子图中的Persistable变量(量化的fakexxxx节点的inscale等参数)没有在LoadCombinedParamsPb时候读取,在LoadCombinedParamsPb函数中加上对所有子图遍历可以trick掉。 这个问题需要和PaddleLite确认如果解决更合理,并在后续PR中修复。
  2. op_device设置为空,需要确认是否有负面影响。

Done.

@yghstill
Copy link
Contributor Author

yghstill commented Dec 5, 2021

Please add UT!

Done.

@yghstill yghstill merged commit 89069af into PaddlePaddle:develop Dec 10, 2021
@yghstill yghstill deleted the support_while_quant_post branch December 10, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants