[Eager] generate eager core ops, only 4 ops #37813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… eager_python_c_api
… eager_python_c_api
… eager_python_c_api
JiabinYang
reviewed
Dec 7, 2021
| @@ -81,13 +82,36 @@ | |||
|
|
|||
|
|
|||
| @signature_safe_contextmanager | |||
| def eager_guard(): | |||
| def eager_mode_place_guard(place): | |||
There was a problem hiding this comment.
it seems we don't need this
There was a problem hiding this comment.
Controller中的Place变量是：std::shared_ptrpaddle::platform::Place expected_place_ = nullptr; 默认是nullptr，如果不先进行place配置（_set_expected_place），执行其它API会崩溃。
jim19930609
previously approved these changes
Dec 7, 2021
| // is not used in imperative mode, so we drop those inputs when generating OP | ||
| // functions. While, for very few OPs, the dispensable inputs are used, we | ||
| // need to manually specify them in this map. | ||
| std::map<std::string, std::set<std::string>> op_ins_map = { |
There was a problem hiding this comment.
In a former PR, I moved some of these maps (for now, only "op_ins_map" and "op_outs_map") to a header file at "paddle/fluid/pybind/op_function_generator.h", so different code generators can share the global maps.
Let's rearrange this part in a separate PR.
There was a problem hiding this comment.
我在本PR重新调整了这些数组，感谢！
zhiqiu
reviewed
Dec 7, 2021
zhiqiu
previously approved these changes
Dec 7, 2021
TCChenlong
previously approved these changes
Dec 7, 2021
wanghuancoder
dismissed stale reviews from TCChenlong, zhiqiu, and XiaoguangHu01
via
4098851
raindrops2sea
approved these changes
Dec 8, 2021
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* refine a test case, test=develop * publish python c api for eager, test=develop * revert modify about test_allclose_layer.py, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * delete numpy includes, use pybind11 numpy.h, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * suport eager error msg, and add grad test case, test=develop * refine, test=develop * refine, test=develop * generate eager core ops, only 4 ops, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
本PR初步调通Eager模式下，4个OP向Python端暴露，具体提交内容包括：