Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet_executor] Take task node from python side #38083

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Dec 13, 2021

PR types

Others

PR changes

Others

Describe

Take task node from python side

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu requested review from LiYuRio and wangxicoding and removed request for LiYuRio December 13, 2021 10:03
if (task_nodes.size() == 0) {
runtime_graph_ = std::make_shared<RuntimeGraph>(program_desc, exe_desc_);
} else {
runtime_graph_ = std::make_shared<RuntimeGraph>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个的gc是不是没有了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python端切完之后,这里暂时没办法get到skip var是什么,每个task node都是一个片段

Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxicoding wangxicoding merged commit 7eb121d into PaddlePaddle:develop Dec 14, 2021
@FeixLiu FeixLiu deleted the take_task_node branch December 14, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants