[Auto parallel] Make sure the id semantics of every var and op unique #38132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
aoyulong
force-pushed
the
auto_para_completion
branch
from
9505744
to
880078a
Compare
… auto_para_completion
chenwhql
reviewed
Dec 30, 2021
| @@ -239,6 +243,10 @@ class Node { | |||
| int desc_order_; | |||
| int block_id_{-1}; | |||
|
|
|||
| // Store the original id of var desc or op desc. | |||
| // Only use this for auto parallel. | |||
| uint64_t original_desc_id_{0}; | |||
There was a problem hiding this comment.
如果明确该成员及相关构造函数仅用于自动并行的话，有没有可能通过继承实现？仅用于某一功能的成员放到基类中，设计上是不太好的，或者说此类成员在自动并行开发完善的过程中还是否会新增？还会新增多少？
这个可能要根据你们的实际情况来判断，如果确实必须加到全局基类中，我建议命名上直接带上功能信息，比如auto_parallel_id_，明确这一成员的使用是有特定场景要求的，避免大家没看注释的时候困惑或者误用
There was a problem hiding this comment.
自动并行目前在python侧，采用非侵入式标记program方式，所以直接复用vardesc和opdesc，id和original_id应该是仅有需求，如果还增加新的，的确要考虑继承或者分拆类，另外未来稳定后，可能不需要这些id，这只是中间状态。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
idof every var desc and op desc be unique.original_idto record the serial desc which the distributed one copies from.GenerateIdtoprivate.