Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet_executor] run time graph on python side #38164

Merged
merged 22 commits into from
Dec 17, 2021

Conversation

FeixLiu
Copy link
Contributor

@FeixLiu FeixLiu commented Dec 15, 2021

PR types

Others

PR changes

Others

Describe

replace the c++ side runtime_graph with the python side one_f_one_b function.

loss compare on GPT2 with pp=mp=dp=2
pr

TODO List:

  1. Move the whole graph cutting from c++ to python.
  2. Remove all RuntimeGraph
  3. Update the python configuration entrance
  4. Adapt for interleaved

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FeixLiu FeixLiu requested review from LiYuRio and wangxicoding and removed request for LiYuRio December 16, 2021 01:36
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

int64_t interceptor_id = task_node->task_id();
interceptor_id_to_task.emplace(interceptor_id, task_node);
}
runtime_graph_->SetInterceptorIdToRank(task_id_to_rank);
runtime_graph_->SetInterceptorIdToNode(interceptor_id_to_task);
for (auto& unique_op : ops) {
unique_op.release();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌚

}


def is_optimizer_op(op_role):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个在其它文件应该有,或许可以放一起

@FeixLiu FeixLiu merged commit fc70136 into PaddlePaddle:develop Dec 17, 2021
@FeixLiu FeixLiu deleted the 1f1b_on_python branch March 2, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants