[FleetExecutor] Move SendIntra to Carrier && Using BlockingQueue #38322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
approved these changes
Dec 22, 2021
| const std::unordered_map<int64_t, std::string>& rank_to_addr, | ||
| const std::string& addr); | ||
|
|
||
| bool IsInit() const; | ||
|
|
||
| // called by Interceptor, send InterceptorMessage to dst | ||
| bool Send(const InterceptorMessage& interceptor_message); | ||
| bool Send(int64_t dst_rank, const InterceptorMessage& interceptor_message); |
There was a problem hiding this comment.
这个为啥要加dst_rank，不是从msg里面可以获取吗
|
|
||
| #if defined(PADDLE_WITH_DISTRIBUTE) && defined(PADDLE_WITH_PSCORE) && \ | ||
| !defined(PADDLE_WITH_ASCEND_CL) | ||
| // send the message inter rank (dst is different rank with src) | ||
| bool SendInterRank(const InterceptorMessage& interceptor_message); | ||
| bool SendInterRank(int64_t dst_rank, |
FeixLiu
approved these changes
Dec 22, 2021
| @@ -29,26 +29,26 @@ class RuntimeGraph final { | |||
| public: | |||
| RuntimeGraph() = default; | |||
| ~RuntimeGraph() = default; | |||
| const std::unordered_map<int64_t, TaskNode*>& intercepter_id_to_node() const { | |||
| return intercepter_id_to_node_; | |||
| const std::unordered_map<int64_t, TaskNode*>& interceptor_id_to_node() const { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe