[Eager] Support EagerTensor initialization with kwargs #38488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
JiabinYang
reviewed
Dec 30, 2021
| self.assertTrue(egr_tensor24.place._equals(place)) | ||
| self.assertTrue(np.array_equal(egr_tensor24.numpy(), x)) | ||
|
|
||
| def test_constructor_with_kwargs(self): |
There was a problem hiding this comment.
Miss some case like kwargs first and then args
There was a problem hiding this comment.
This is a case of a syntax error：kwargs first and then args case,
SyntaxError: positional argument follows keyword argument.
There was a problem hiding this comment.
SyntaxError could not be catch, maybe hard to test.
JiabinYang
previously approved these changes
Jan 4, 2022
| self.assertTrue(egr_tensor24.place._equals(place)) | ||
| self.assertTrue(np.array_equal(egr_tensor24.numpy(), x)) | ||
|
|
||
| def test_constructor_with_kwargs(self): |
veyron95
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe