[Unify Tensors PR #5] framework::Tensor inherits from DenseTensor,test=allcases #38632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faces accordingly
… allocation_rearrange_pr
… allocation_rearrange_pr
… allocation_rearrange_pr PaddlePaddle#2
… allocation_rearrange_pr
… densetensor_interface_change
…to pten::DenseTensor
… densetensor_interface_change
… densetensor_interface_change
… densetensor_interface_change
… densetensor_interface_change
… densetensor_interface_change
… densetensor_interface_change
|
Thanks for your contribution! |
… densetensor_interface_change
… densetensor_interface_change
jim19930609
force-pushed
the
tensor_inherit_from_dense_tensor
branch
from
513b868
to
7c6b10f
Compare
jim19930609
force-pushed
the
tensor_inherit_from_dense_tensor
branch
from
648a699
to
c8737e8
Compare
jim19930609
force-pushed
the
tensor_inherit_from_dense_tensor
branch
from
c8737e8
to
d35f7d1
Compare
jim19930609
force-pushed
the
tensor_inherit_from_dense_tensor
branch
from
d35f7d1
to
1d38ca0
Compare
… tensor_inherit_from_dense_tensor
jim19930609
force-pushed
the
tensor_inherit_from_dense_tensor
branch
from
6fa06a6
to
2d91053
Compare
… tensor_inherit_from_dense_tensor
jim19930609
force-pushed
the
tensor_inherit_from_dense_tensor
branch
from
f8c4a19
to
9b62071
Compare
Shixiaowei02
approved these changes
Jan 7, 2022
Please describe the reason behind the change more clearly. |
raindrops2sea
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Previous works on constructing new tensor library "pten" introduced another Tensor type namely "DenseTensor", which temporarily co-exists with framework::Tensor and LoDTensor. In this series of PRs, we attempt to replace legacy "framework::Tensor and LoDTensor" by the newly implemented "DenseTensor", so as to facilitate the progress of "pten" joining original framework.
In this PR, we moved nearly all the members and interfaces from framework::Tensor to pten::DenseTensor, and then asked framework::Tensor to inherit from pten::DenseTensor. Note that interfaces (Split, Chunk, Slice, ...) with "framework::Tensor" as return will remain on framework::Tensor for now.
After this patch, all the original access to framework::Tensor interfaces will be re-routed
to accessing the corresponding interfaces on pten::DenseTensor, whereas framework::Tensor will become a simple wrapper that almost holds nothing.