[Dist Pass] Amp Pass #38764
Merged
[Dist Pass] Amp Pass #38764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rding-stage-1-2-3
…rding-stage-1-2-3
|
Thanks for your contribution! |
aoyulong
reviewed
Jan 10, 2022
| @@ -185,10 +188,9 @@ def _get_dist_program(self, rank, dist_context=None, relaunch_phase=False): | |||
| self._parameter_list, self._no_grad_set, self._callbacks) | |||
|
|
|||
| # serial forward pass | |||
| self._apply_serial_pass(completed_main_program, serial_startup_program) | |||
|
|
|||
| self._apply_serial_pass(completed_main_program, serial_startup_program, | |||
There was a problem hiding this comment.
Please change _apply_serial_pass() to _apply_pre_passes() and change _apply_post_optimization_passed to _apply_post_passes.
aoyulong
reviewed
Jan 10, 2022
| from ..dist_attribute import OperatorDistributedAttribute | ||
| from paddle.distributed.auto_parallel.process_group import get_world_process_groups | ||
|
|
||
| global_process_mesh = get_world_process_groups().ranks |
There was a problem hiding this comment.
Please change get_world_process_groups() to get_world_process_group().
There was a problem hiding this comment.
fixed, though it is not my fault~ lol
aoyulong
reviewed
Jan 10, 2022
| g_dist_attr.dims_mapping) | ||
| self.dist_context.set_op_dist_attr_for_program(new_op, new_op_dist_attr) | ||
|
|
||
| main_block._sync_with_cpp() |
There was a problem hiding this comment.
Please add the necessary comments, especially for the methods without underscores.
aoyulong
previously approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe