Fix mkldnn invalid infershape impl #38837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
Fix mkldnn invalid infershape impl
The external information to be used in the
InferShapefunction of the op needs to be passed in through theInferShapeContext. Even the information in current op should not be used.When registering the OP, the
InferShapefunction of the OP is stored as a member pointer ofOpInfo. This member pointer may be used independently of the op. If theInferShapefunction relies on the internal member information of the OP, the inference results independent of the OP and bound with the op will be different, which will be wrong in some scenarios.Therefore, this PR uniformly modifies the behavior of OP members directly used in some mkldnn related
InferShapefunctions.related PR: #38776