[part 5]change type of function args #38889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhangting2020
force-pushed
the
elementwise_ops5
branch
from
2abd482
to
bf86b84
Compare
Xreki
reviewed
Jan 12, 2022
| return std::llrint( | ||
| std::pow(static_cast<double>(args[0]), static_cast<double>(args[1]))); | ||
| std::pow(static_cast<double>(a), static_cast<double>(b))); |
zhangting2020
force-pushed
the
elementwise_ops5
branch
from
bf86b84
to
7804826
Compare
zhangting2020
force-pushed
the
elementwise_ops5
branch
from
7804826
to
40ccb07
Compare
Xreki
reviewed
Jan 13, 2022
| T res = fmod(a, b); | ||
| if ((res != 0) && ((b < 0) != (res < 0))) res += b; | ||
| T res = b % a; | ||
| if ((res != 0) && ((res < 0) != (a < 0))) res += a; | ||
| return res; | ||
| } | ||
| }; |
There was a problem hiding this comment.
InverseModFunctorFP是CPU下，x_dims.size() < y_dims.size()时用到的，暂时没有改动这个接口。只是原来的实现Mod和InverseMode的位置问题，导致diff显示修改了InverseModFunctor
|
|
||
| // Accoding to #PR26732: in dividen % divsor | ||
| // remainder shall have the same sign as divsor. | ||
| if ((res != 0) && ((b ^ res) < 0)) res += b; |
There was a problem hiding this comment.
这里没问题，Mod用的b，InverseMod用的a
Xreki
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimizationPR changes
OPsDescribe
[part 5]change type of function args因 #38859 支持不同输入类型的elementwise op，需要修改计算函数的参数为值传递