[PTen]Separate origin Kernel and add Kernel for C++ API #39002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
previously approved these changes
Jan 20, 2022
| @@ -22,104 +22,126 @@ limitations under the License. */ | |||
|
|
|||
| namespace pten { | |||
There was a problem hiding this comment.
math里面的这些kernel，raw_kernel, dev_api的顺序后面也许可以整理一下，kernel太多了找起来会有点麻烦
| @@ -130,7 +127,6 @@ | |||
| param : [x, y, -1] | |||
There was a problem hiding this comment.
kernel参数对齐API以后InterMeta的参数是不是也有和API保持一致的可能？
| @@ -172,7 +167,7 @@ | |||
| param: [x, axis, keep_dim, dtype] | |||
| kernel : | |||
| func : sum | |||
| param : [x, axis, keep_dim, false, DataType::UNDEFINED] | |||
| param : [x, axis, keep_dim] | |||
There was a problem hiding this comment.
这里能否使sum kernel的参数和API保持一致？
chenwhql
previously approved these changes
Jan 20, 2022
| @@ -142,24 +142,25 @@ class ElementwiseOp : public framework::OperatorWithKernel { | |||
| const framework::ExecutionContext &ctx) const override { | |||
| if (Type() == "elementwise_add") { | |||
| if (ctx.InputVar("X")->IsType<framework::LoDTensor>()) { | |||
| return framework::KernelSignature("add", {"X", "Y"}, {"axis"}, {"Out"}); | |||
| return framework::KernelSignature("add_raw", {"X", "Y"}, {"axis"}, | |||
There was a problem hiding this comment.
这里要既能找到raw也能找到非raw的吧，axis值无效的时候，直接使用非raw，raw是用来保底的
chenwhql
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
对Kernel分层，为C++ API添加新的注册Kernel，原始xxxKernel更改为xxxRawKernel