Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move selected_rows PR #1] Renamed selected_rows.* to selected_rows_utils.* #39037

Merged

Conversation

veyron95
Copy link
Contributor

@veyron95 veyron95 commented Jan 19, 2022

PR types

Others

PR changes

Others

Describe

A series of jobs where selected_rows moves from Fluid to Pten.
There are 5 PR to complete the migration work in expected.

This is PR 1: Renamed selected_rows.* to selected_rows_utils.*

follow-up work:

PR 2: Add SelectedRows.* to Pten.
PR 3: Change the relationship of [include/Cmake].
PR 4: SelectedRows inherits from TensorBase.
PR 5: VisitDataType -> Pten::DataType.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@veyron95 veyron95 changed the title [Move selected_rows PR #1] Renamed selected_rows.* -> selected_rows_utils.* [Move selected_rows PR #1] Renamed selected_rows.* to selected_rows_utils.* Jan 19, 2022
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单测名称更改

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants