Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring Tensor PR #7] differentiate deprecated interfaces #39228

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

Shixiaowei02
Copy link
Contributor

@Shixiaowei02 Shixiaowei02 commented Jan 25, 2022

PR types

Function optimization

PR changes

APIs

Describe

目前 DenseTensor 处于一个中间态。使用单独的源文件存放待清理的接口(如依赖其它第三方库的),以便其它上层框架依赖。达到最终态后,这个单独的文件将重新合并。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Shixiaowei02 Shixiaowei02 force-pushed the dev/tensor_include branch 2 times, most recently from da23fb0 to 63371a7 Compare January 25, 2022 13:00
@Shixiaowei02 Shixiaowei02 changed the title splits the dense tensor, test=develop [Refactoring Tensor PR #6] differentiate deprecated interfaces Jan 26, 2022
@Shixiaowei02 Shixiaowei02 changed the title [Refactoring Tensor PR #6] differentiate deprecated interfaces [Refactoring Tensor PR #7] differentiate deprecated interfaces Jan 26, 2022
inline bool IsInitialized() const { return holder_ != nullptr; }

template <typename T>
T* data();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data也不需要吗?还是说要加mutable_data了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我建议留 data() 接口,下个相关的PR中我移回来,并且补全注释

@Shixiaowei02 Shixiaowei02 merged commit 3047085 into PaddlePaddle:develop Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants