Move compare OPs to phi #39970
Merged
Move compare OPs to phi #39970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
YuanRisheng
reviewed
Feb 28, 2022
| ctx.template Alloc<bool>(out); | ||
| std::vector<const DenseTensor*> ins{&x, &y}; | ||
| std::vector<DenseTensor*> outs{out}; | ||
| paddle::operators::LaunchElementwiseCudaKernel<ElementwiseType::kBinary, |
There was a problem hiding this comment.
代码已经迁到phi下，使用funcs下的BroadcastKernel替代
|
|
||
| std::vector<const DenseTensor*> ins{&x, &y}; | ||
| std::vector<DenseTensor*> outs{&tmp}; | ||
| paddle::operators::LaunchSameDimsElementwiseCudaKernel<bool>( |
There was a problem hiding this comment.
代码已经迁到phi下，使用ElementwiseKernel替代
Comment on lines
20
to
21
| #include "paddle/fluid/operators/elementwise/elementwise_op_broadcast.cu.h" | ||
| #include "paddle/fluid/operators/elementwise/elementwise_op_impl.cu.h" |
zyfncg
reviewed
Feb 28, 2022
|
|
||
| #include "paddle/phi/kernels/compare_kernel.h" | ||
|
|
||
| #include "paddle/phi/core/dense_tensor.h" |
There was a problem hiding this comment.
dense_tensor.h应该不需要include了
Comment on lines
+19
to
+46
| KernelSignature LessThanArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("less_than", {"X", "Y"}, {"axis"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature LessEqualArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("less_equal", {"X", "Y"}, {"axis"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature GreaterThanArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("greater_than", {"X", "Y"}, {"axis"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature GreaterEqualArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("greater_equal", {"X", "Y"}, {"axis"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature EqualArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("equal", {"X", "Y"}, {"axis"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature NotEqualArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("not_equal", {"X", "Y"}, {"axis"}, {"Out"}); | ||
| } | ||
|
|
||
| KernelSignature EqualAllArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("equal_all", {"X", "Y"}, {}, {"Out"}); | ||
| } | ||
|
|
There was a problem hiding this comment.
此OP实现较特殊，去掉映射函数的话InferShape会报错（原因不明）：
zyfncg
previously approved these changes
Mar 1, 2022
YuanRisheng
previously approved these changes
Mar 1, 2022
… move-compare-op-to-phi
zyfncg
previously approved these changes
Mar 2, 2022
YuanRisheng
previously approved these changes
Mar 2, 2022
… move-compare-op-to-phi
zyfncg
approved these changes
Mar 3, 2022
YuanRisheng
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
Move a series of compare OPs to phi, including less_than, less_equal, greater_than, greater_equal, equal, not_equal, and equal_all.