Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phi] move sigmoid_cross_entopy_with_logits log_loss cumsum auc kernel to phi #39976

Merged
merged 13 commits into from
Mar 4, 2022
Merged

[phi] move sigmoid_cross_entopy_with_logits log_loss cumsum auc kernel to phi #39976

merged 13 commits into from
Mar 4, 2022

Conversation

linjieccc
Copy link
Contributor

@linjieccc linjieccc commented Feb 27, 2022 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

move op kernels to phi

  • sigmoid_cross_entopy_with_logits
  • log_loss
  • cumsum
  • auc

TODO: Move InferShape funcs.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@linjieccc linjieccc changed the title [phi] move sigmoid cross entopy with logits to phi [phi] move sigmoid_cross entopy_with_logits log_loss cumsum to phi Feb 28, 2022
@linjieccc linjieccc changed the title [phi] move sigmoid_cross entopy_with_logits log_loss cumsum to phi [phi] move sigmoid_cross_entopy_with_logits log_loss cumsum kernel to phi Feb 28, 2022
@linjieccc linjieccc changed the title [phi] move sigmoid_cross_entopy_with_logits log_loss cumsum kernel to phi [phi] move sigmoid_cross_entopy_with_logits log_loss cumsum auc kernel to phi Mar 1, 2022
zyfncg
zyfncg previously approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigmoid_cross_entopy_with_logits，log_loss，auc似乎目前还没有op-benchmark脚本，请
@ZzSean 看下是否需要添加

paddle/phi/kernels/gpu/sigmoid_cross_entropy_with_logits_kernel.cu Outdated Show resolved Hide resolved
paddle/phi/kernels/impl/log_loss_kernel_impl.h Outdated Show resolved Hide resolved
YuanRisheng
YuanRisheng reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个op有benchmark脚本吗

@linjieccc
Copy link
Contributor Author

linjieccc commented Mar 2, 2022 •
edited
Loading

这几个op有benchmark脚本吗

@YuanRisheng
cumsum和sigmoid_cross_entopy_with_logits已有对应脚本，
log_loss脚本已添加：PaddlePaddle/benchmark#1327
auc暂时不需要添加
@ZzSean 辛苦再确认下

ZzSean
ZzSean previously approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark。相关脚本已经添加完成

YuanRisheng
YuanRisheng previously approved these changes Mar 2, 2022
View reviewed changes
chenwhql
chenwhql previously approved these changes Mar 2, 2022
View reviewed changes
XiaoguangHu01
XiaoguangHu01 previously approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZzSean
ZzSean approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

XiaoguangHu01
XiaoguangHu01 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit b7bbe39 into PaddlePaddle:develop Mar 4, 2022
@linjieccc linjieccc deleted the move_ops branch March 4, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

@MingMingShangTian MingMingShangTian MingMingShangTian approved these changes

@chenwhql chenwhql chenwhql approved these changes

@ZzSean ZzSean ZzSean approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@YuanRisheng YuanRisheng YuanRisheng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@linjieccc @zyfncg @MingMingShangTian @chenwhql @YuanRisheng @ZzSean @XiaoguangHu01