[Phi]Move topk kernel to phi #40064
Merged
[Phi]Move topk kernel to phi #40064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Mar 8, 2022
paddle/phi/kernels/funcs/transpose.h
Outdated
| @@ -0,0 +1,61 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这里能否试下直接用transpose_kernel.h中的Transpose，phi已经有两套transpose的封装了
paddle/phi/kernels/top_k_kernel.h
Outdated
| template <typename T, typename Context> | ||
| void TopkKernel(const Context& dev_ctx, | ||
| const DenseTensor& x, | ||
| paddle::optional<const DenseTensor&> k_t, |
There was a problem hiding this comment.
这种需要使用Scalar，而不是保留两个参数，麻烦参考scale kernel的scale参数修改一下
paddle/phi/ops/compat/top_k_sig.cc
Outdated
| namespace phi { | ||
|
|
||
| KernelSignature TopkOpArgumentMapping(const ArgumentMappingContext& ctx) { | ||
| return KernelSignature("top_k", |
YuanRisheng
reviewed
Mar 8, 2022
| @@ -51,6 +51,19 @@ namespace operators { | |||
|
|
|||
| using Tensor = framework::Tensor; | |||
|
|
|||
| inline void GetDims(const phi::DDim& dim, int axis, int* pre, int* n, | |||
There was a problem hiding this comment.
这个文件可以迁到phi的funcs下，虽然代码量较大，但迁移难度应该不大
There was a problem hiding this comment.
有其他文件依赖这个头文件，如果迁移了这个文件，文件数和改动行数都会超过限制，后面PR再改吧
zyfncg
reviewed
Mar 8, 2022
paddle/phi/kernels/funcs/transpose.h
Outdated
| namespace funcs { | ||
|
|
||
| template <typename Context, typename T> | ||
| inline void TransCompute(const int dim, |
There was a problem hiding this comment.
这里的TransCompute如果有复用的话可以和现有的Transpose整合一下，如果仅topk kernel使用的话可以放到topk kernel的文件中
chenwhql
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Move topk kernel to phi