Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] move the graph_send_recv op to the phi #40092

Merged
merged 9 commits into from
Mar 8, 2022

Conversation

wawltor
Copy link
Contributor

@wawltor wawltor commented Mar 2, 2022

PR types

Function optimization

PR changes

OPs

Describe

move the graph_send_recv op to the phi

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 2, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 2, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

};

template <typename T, typename IndexT, typename Functor>
void elementwise_inner_operation(const DenseTensor& src,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数命名不符合代码规范,驼峰命名

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数命名不符合代码规范,驼峰命名

已更改

namespace phi {

template <typename T, typename IndexT, typename Functor>
void graph_send_recv_cpu_for_loop_grad(const int& input_size,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

已更改

Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个op补充了benchmark脚本了吗

#include <algorithm>
#include <vector>

#include "paddle/fluid/operators/eigen/eigen_function.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个头文件有用到吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个头文件有用到吗

没有用到,已删除

Comment on lines +15 to +16
#include "paddle/phi/kernels/gpu/graph_send_recv_funcs.h"
#include "paddle/phi/kernels/graph_send_recv_kernel.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个头文件的顺序可以调下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个头文件的顺序可以调下

已调序

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 6, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 6, 2022
@wawltor
Copy link
Contributor Author

wawltor commented Mar 7, 2022

这个op补充了benchmark脚本了吗

op benchmark已增加

Comment on lines +15 to +16
#include "paddle/phi/kernels/gpu/graph_send_recv_funcs.h"
#include "paddle/phi/kernels/graph_send_recv_grad_kernel.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个头文件的顺序后面可以调一下

@wawltor wawltor merged commit 6bd2d2b into PaddlePaddle:develop Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants