Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【phi】migrate eigh op to phi #40213

Merged
merged 6 commits into from
Mar 9, 2022
Merged

Conversation

Zjq9409
Copy link
Contributor

@Zjq9409 Zjq9409 commented Mar 7, 2022

PR types

Others

PR changes

Others

Describe

迁移eigh算子到phi

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 7, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Zjq9409 Zjq9409 changed the title migrate eigh to phi 【phi】migrate eigh op to phi Mar 7, 2022
paddle/phi/infermeta/unary.cc Show resolved Hide resolved
paddle/phi/kernels/cpu/eigh_grad_kernel.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/eigh_grad_kernel.h Outdated Show resolved Hide resolved
paddle/phi/kernels/impl/eigh_grad_kernel_impl.h Outdated Show resolved Hide resolved
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个op有添加benchmark的脚本吗

paddle/phi/kernels/impl/eigh_grad_kernel_impl.h Outdated Show resolved Hide resolved
@Zjq9409
Copy link
Contributor Author

Zjq9409 commented Mar 7, 2022

这个op有添加benchmark的脚本吗

有添加脚本,PaddlePaddle/benchmark#1325

zyfncg
zyfncg previously approved these changes Mar 8, 2022
YuanRisheng
YuanRisheng previously approved these changes Mar 8, 2022
@Zjq9409 Zjq9409 dismissed stale reviews from YuanRisheng and zyfncg via 8947054 March 8, 2022 10:43
@YuanRisheng YuanRisheng merged commit 2aca8d9 into PaddlePaddle:develop Mar 9, 2022
xiaolao pushed a commit to xiaolao/Paddle that referenced this pull request Mar 15, 2022
* migrate eigh to phi

* optimize code

* modify code according to comment

* conflict resolution
zyfncg pushed a commit that referenced this pull request Mar 16, 2022
* [PHI] Migrate roll op

* 【phi】migrate eigh op to phi (#40213)

* migrate eigh to phi

* optimize code

* modify code according to comment

* conflict resolution

* [PHI] Migrate roll op

* [PHI] Fix converage of roll_sig

* [PHI] Fix infermate of roll_sig

* [Phi] Fix unittest coverage of roll op

* [PHI] Fix infermeta in unary

* [PHI] Fix parameter type of roll op

* [PHI] Fix parameter type of roll op

* [PHI] Fix parameter of roll op

Co-authored-by: crystal <62974595+Zjq9409@users.noreply.github.com>
liqitong-a pushed a commit to liqitong-a/Paddle that referenced this pull request Mar 17, 2022
* [PHI] Migrate roll op

* 【phi】migrate eigh op to phi (PaddlePaddle#40213)

* migrate eigh to phi

* optimize code

* modify code according to comment

* conflict resolution

* [PHI] Migrate roll op

* [PHI] Fix converage of roll_sig

* [PHI] Fix infermate of roll_sig

* [Phi] Fix unittest coverage of roll op

* [PHI] Fix infermeta in unary

* [PHI] Fix parameter type of roll op

* [PHI] Fix parameter type of roll op

* [PHI] Fix parameter of roll op

Co-authored-by: crystal <62974595+Zjq9409@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants