Move psroi_pool OP to phi #40353
Merged
Move psroi_pool OP to phi #40353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Mar 10, 2022
Comment on lines
+138
to
+139
| kernel->InputAt(2).SetDataType( | ||
| paddle::experimental::CppTypeToDataType<int>::Type()); |
There was a problem hiding this comment.
在许多情况下两者应该是一样的。但考虑到原kernel里直接使用的int类型并不是一种跨平台安全的类型，int和INT32类型不等价的情况是允许的，所以这里还是使用CppTypeToDataType让编译器做类型转换更安全一些。
| PD_REGISTER_KERNEL( | ||
| psroi_pool_grad, GPU, ALL_LAYOUT, phi::PsroiPoolGradKernel, float, double) { | ||
| kernel->InputAt(2).SetDataType( | ||
| paddle::experimental::CppTypeToDataType<int>::Type()); |
| #pragma once | ||
|
|
||
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/core/device_context.h" |
| #pragma once | ||
|
|
||
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/core/device_context.h" |
YuanRisheng
reviewed
Mar 10, 2022
| } | ||
|
|
||
| DenseTensor rois_batch_id_list_gpu; | ||
| paddle::framework::TensorCopy( |
There was a problem hiding this comment.
可以看下是否可以使用phi下的copy来替代
MingMingShangTian
approved these changes
Mar 10, 2022
chenwhql
approved these changes
Mar 11, 2022
zyfncg
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
Move psroi_pool OP to phi.