Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] Move assign value op kernel into phi #40967

Merged

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Mar 25, 2022

PR types

Function optimization

PR changes

OPs

Describe

[Phi] Move assign value op kernel into phi

assign_value_op.h有npu kernel深度依赖,暂时不能移除

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 26, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 26, 2022
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -42,6 +44,62 @@ void AssignArrayKernel(const Context& dev_ctx,
}
}

template <typename T, typename Context>
typename std::enable_if<std::is_same<T, bool>::value>::type CopyVecotorToTensor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拼写错误?CopyVectorToTensor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

额,copy过来没注意原先就拼错了,下个PR一起fix下

@chenwhql chenwhql merged commit 324b6b7 into PaddlePaddle:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants