fix bug of inplace fill_ and zero_ API #41229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR's description meets the template requirements! |
|
你的PR提交成功，感谢你对开源项目的贡献! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
对于
fill_和zero_inplace API，输入在CUDAPinnedPlace上时，输出会被拷贝到CUDAPlace上。使用
ModifyInplaceInput只将输出的meta信息赋值给输入，输入的impl信息还是输入Tensor。导致对上述场景，输出为
CUDAPinnedPlace上的值。与老动态图行为不一致。使用
GetOutput，将输出的impl信息整个赋给输入。这样输入的TensorBase也变成了输出。将会输出
CUDAPlace上的值。