Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

统一ps refine #41234

Merged
merged 17 commits into from
Apr 2, 2022
Merged

统一ps refine #41234

merged 17 commits into from
Apr 2, 2022

Conversation

zhaocaibei123
Copy link
Contributor

@zhaocaibei123 zhaocaibei123 commented Mar 31, 2022

PR types

Others

PR changes

Others

Describe

  1. unify function naming in ps: under score case => camel case
  2. remove Context and Pull/Push/Load/Save inferface in PSClient

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 31, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

fuyinno4
fuyinno4 previously approved these changes Apr 1, 2022
@zhaocaibei123 zhaocaibei123 changed the title Async refine 统一ps refine Apr 1, 2022
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyinno4 fuyinno4 merged commit b3270ad into PaddlePaddle:develop Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants