Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【code format check upgrade】 step2:clang-format #42840

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

betterpig
Copy link
Contributor

@betterpig betterpig commented May 18, 2022

PR types

Others

PR changes

Others

Describe

code style check and format. record the formated result of all c++ file using new version clang-format 13.0.0.
some points:

  • block format of headers in two files paddle/phi/kernels/gpu/gelu_grad_kernel.cu and paddle/fluid/pybind/[eager_utils.cc](http://eager_utils.cc/), their headers are a little strange and can not be sorted according to google C++ style. If formated, will cause compilint error of "identifier xx is undefined".

foeterefoeeretert1er1 MItA TofAMI

E.g:
image

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@betterpig betterpig changed the title 【No merge】test new version Clang format 【No merge】record new version Clang format May 18, 2022
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Jun 4, 2022

windows流水线上test_fused_multi_transformer_op失败了,可以先跳过fused_multi_transformer.cc.cu的格式化

@betterpig betterpig changed the title 【No merge】record new version Clang format 【code format check upgrade】 step2:clang-format Jun 5, 2022
@luotao1 luotao1 merged commit a3730dc into PaddlePaddle:develop Jun 5, 2022
fuyou765 pushed a commit to fuyou765/Paddle that referenced this pull request Jun 7, 2022
@betterpig betterpig deleted the clang_format branch June 8, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants