Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【code format check upgrade】 step1: pre-commit, remove-ctrlf, pylint #43103

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

betterpig
Copy link
Contributor

@betterpig betterpig commented May 30, 2022

PR types

Others

PR changes

Others

Describe

code format check upgrade step1: pre-commit, remove-ctrlf, pylint
7cc9b336e09064beaaa1fc6ecb441dd4
https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/5747810/job/15351218

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@betterpig betterpig force-pushed the code_check1 branch 2 times, most recently from e300757 to 1da6e5b Compare May 30, 2022 13:08
@betterpig betterpig changed the title code format check upgrade step1: pre-commit, remove-ctrlf, pylint 【code format check upgrade】 step1: pre-commit, remove-ctrlf, pylint May 31, 2022
@betterpig betterpig merged commit 664758f into PaddlePaddle:develop Jun 1, 2022

if ! [[ $(pre-commit --version) == *"2.17.0"* ]]; then
pip install pre-commit==2.17.0
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以之后把pre-commit, remove-ctrlf, pylint都打入镜像,避免CI 每次重新安装

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


if ! [[ $(pre-commit --version) == *"2.17.0"* ]]; then
pip install pre-commit==2.17.0
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以之后把pre-commit, remove-ctrlf, pylint都打入镜像,避免CI 每次重新安装

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@betterpig betterpig deleted the code_check1 branch June 8, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants