Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fc on bfloat16 #43154

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Enable fc on bfloat16 #43154

merged 9 commits into from
Jun 2, 2022

Conversation

tsocha
Copy link
Contributor

@tsocha tsocha commented Jun 1, 2022

PR types

Performance optimization

PR changes

OPs

Describe

This change have a huge impact on bfloat16 performance on VIT-OCR model.

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Jun 1, 2022
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 1, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja requested a review from wozna June 1, 2022 09:49
jczaja
jczaja previously approved these changes Jun 1, 2022
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wozna
wozna previously approved these changes Jun 1, 2022
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsocha tsocha dismissed stale reviews from wozna and jczaja via 7700901 June 1, 2022 13:38
@tsocha tsocha requested review from jczaja and wozna June 1, 2022 13:41
Copy link
Member

@Silv3S Silv3S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit cb1a0ec into PaddlePaddle:develop Jun 2, 2022
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 2, 2022

你的PR已合入Paddle库,请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@tsocha tsocha deleted the fc-as-bf16 branch June 2, 2022 14:22
fuyou765 pushed a commit to fuyou765/Paddle that referenced this pull request Jun 7, 2022
* Enable fc on bfloat16

* Add pass for residual connection

* Dissable Residual connection pass for now

* Ban ResidualData from DQ

* style

* WO for python tests
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants