Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matmul+activation fuse pass #43519

Merged
merged 38 commits into from
Jul 12, 2022
Merged

matmul+activation fuse pass #43519

merged 38 commits into from
Jul 12, 2022

Conversation

Silv3S
Copy link
Member

@Silv3S Silv3S commented Jun 14, 2022 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

  • fuse matmul_v1 with all supported activations,
  • add required unit tests.

@Silv3S Silv3S added the Intel label Jun 14, 2022
@paddle-bot-old
Copy link

Sorry to inform you that e0de057's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@Silv3S Silv3S closed this Jun 30, 2022
@Silv3S Silv3S requested a review from tsocha July 4, 2022 14:44
jakpiase
jakpiase previously approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silv3S Silv3S requested a review from tsocha July 5, 2022 15:15
tsocha
tsocha suggested changes Jul 6, 2022
View reviewed changes
paddle/fluid/platform/mkldnn_reuse.h Outdated Show resolved Hide resolved
paddle/fluid/operators/mkldnn/conv_mkldnn_op.cc Outdated Show resolved Hide resolved
@Silv3S Silv3S requested a review from tsocha July 7, 2022 07:16
@Silv3S
Copy link
Member Author

Silv3S commented Jul 7, 2022

@jiangjiajun please review

@Silv3S
Copy link
Member Author

Silv3S commented Jul 7, 2022

@XiaoguangHu01 could you please approve exceeding the limit of modified files?

@Silv3S
Copy link
Member Author

Silv3S commented Jul 7, 2022

@chalsliu could you please approve setting TIMEOUT for newly added unit test?

tsocha
tsocha previously approved these changes Jul 7, 2022
View reviewed changes
@jczaja jczaja self-requested a review July 7, 2022 09:44
jczaja
jczaja previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piotrekobi
piotrekobi previously approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@piotrekobi piotrekobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Silv3S Silv3S dismissed stale reviews from piotrekobi, jczaja, and tsocha via a8368b9 July 11, 2022 08:36
@jczaja jczaja merged commit 3333a43 into PaddlePaddle:develop Jul 12, 2022
@paddle-bot
Copy link

paddle-bot bot commented Jul 12, 2022

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

@Silv3S Silv3S deleted the matmul_activation branch July 12, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczaja jczaja jczaja approved these changes

@tsocha tsocha tsocha left review comments

@piotrekobi piotrekobi piotrekobi left review comments

@jakpiase jakpiase jakpiase left review comments

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Silv3S @jczaja @tsocha @piotrekobi @jakpiase