[Dy2Static] Add non-local for while and for. #43864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Jun 28, 2022
|
|
||
| return loop_vars | ||
|
|
||
|
|
||
| def _run_paddle_while_loop(cond, body, loop_vars): | ||
| def _run_paddle_while_loop(cond, body, getter, setter): |
There was a problem hiding this comment.
Suggested change
| def _run_paddle_while_loop(cond, body, getter, setter): | |
| def _run_paddle_while(cond, body, getter, setter): |
| def _run_py_while(cond, body, getter, setter): | ||
| loop_vars = getter() | ||
| while cond(): | ||
| loop_vars = body() |
There was a problem hiding this comment.
这里不需要调用setter来同步body里的修改么？
There was a problem hiding this comment.
这个是不需要调用setter的。因为我们的body中的修改是non local的，那么他的修改就是原来的变量。只有的paddle的时候才需要修改。
| body_new_vars = set([ | ||
| var for var in _vars_with_store(if_vars_dict) | ||
| if var not in parent_vars_dict | ||
| if var not in parent_vars_dict and var != "__args" |
There was a problem hiding this comment.
Suggested change
| if var not in parent_vars_dict and var != "__args" | |
| if var not in parent_vars_dict and var != ARGS_NAME |
| ]) | ||
| orelse_new_vars = set([ | ||
| var for var in _vars_with_store(else_vars_dict) | ||
| if var not in parent_vars_dict | ||
| if var not in parent_vars_dict and var != "__args" |
There was a problem hiding this comment.
Suggested change
| if var not in parent_vars_dict and var != "__args" | |
| if var not in parent_vars_dict and var != ARGS_NAME |
| @@ -39,10 +41,11 @@ | |||
| FOR_BODY_PREFIX = 'for_loop_body' | |||
| GENERATE_VARIABLE_PREFIX = 'generate_variable' | |||
|
|
|||
| ATTRIBUTE_VARIABLE_PREFIX = '__attribute_variable' | |||
| ARGS_NAME = '__args' | |||
There was a problem hiding this comment.
ifelse_transformer.py 里有一个ARGS_NAME，可以考虑复用下
Aurelius84
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Pass the test_loop.py