Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UT failures #45099

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fix UT failures #45099

merged 1 commit into from
Aug 31, 2022

Conversation

leo0519
Copy link
Collaborator

@leo0519 leo0519 commented Aug 12, 2022

PR types

Bug fixes

PR changes

Others

Describe

Fix the following UT failures

  1. test_post_training_quantization_mobilenetv1
  2. test_post_training_quantization_resnet50
  3. test_einsum_v2
  4. test_trt_convert_reduce_sum
  5. test_save_load_binary
  6. test_trt_flatten2_matmul_fuse_pass.py
  7. test_trt_pool_op
  8. test_trt_reduce_mean_op
  9. test_trt_convert_conv2d
  10. test_trt_convert_instance_norm
  11. test_trt_poop3d_op

@paddle-bot
Copy link

paddle-bot bot commented Aug 12, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 12, 2022
@leo0519 leo0519 added the NVIDIA label Aug 12, 2022
@leo0519 leo0519 force-pushed the ut-fix branch 2 times, most recently from 46b43bd to 75efbfc Compare August 12, 2022 06:59
luotao1
luotao1 reviewed Aug 15, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/ir/inference/inference_pass_test.py Outdated
paddle_out,
rtol=rtol,
atol=atol,
err_msg="Output has diff between GPU and TensorRT.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qili93 因为 #44988 替换了全量的assert_allclose，文件量较大，可以等#44988 先merge么？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的，到時我再解 conflict~

Wangzheee
Wangzheee previously approved these changes Aug 19, 2022
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Aug 22, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

qili93
qili93 previously approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 requested a review from XieYunshen August 25, 2022 06:14
XieYunshen
XieYunshen previously approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(test_post_training_quantization_mobilenetv1 PROPERTIES TIMEOUT 900 LABELS "RUN_TYPE=NIGHTLY")

@qili93
Copy link
Contributor

qili93 commented Aug 25, 2022

hi, @leo0519

This PR has a conflict, would you please help to resolve, thanks !

@leo0519 leo0519 dismissed stale reviews from XieYunshen, qili93, and Wangzheee via 69244aa August 25, 2022 08:16
@leo0519
Copy link
Collaborator Author

leo0519 commented Aug 26, 2022 •
edited
Loading

Hi @qili93 ,
I solved the conflict and the CI passed, but this PR needs to be reviewed again.
Could you please help me merge this PR? Thank you!

qili93
qili93 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 1ac8ca4 into PaddlePaddle:develop Aug 31, 2022
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 left review comments

@qili93 qili93 qili93 approved these changes

@Wangzheee Wangzheee Wangzheee left review comments

@XieYunshen XieYunshen XieYunshen left review comments

Assignees

@luotao1 luotao1

@qili93 qili93

Labels
NVIDIA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leo0519 @CLAassistant @qili93 @luotao1 @Wangzheee @XieYunshen