Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eager] delete final state pre-name #45306

Merged
merged 58 commits into from
Aug 26, 2022

Conversation

wanghuancoder
Copy link
Contributor

@wanghuancoder wanghuancoder commented Aug 22, 2022

PR types

Others

PR changes

Others

Describe

动态图早期,为了区分中间态和最终态,将最终态PythonC暴露的API叫做final_state_xxx,这非常不利于其它开发者理解。
本PR删除所有final_state的前缀。
本PR之前,python端调用PythonC暴露的API的方法是:

  • 老动态图调用_C_ops.xxx, 对应 C++中的op_function.cc
  • 中间态兼容老动态图,也调用_C_ops.xxx, 但对应的C++代码是eager_op_function.cc
  • 最终态,调用_C_ops.final_state_xxx,对应C++代码是eager_final_state_op_function.cc

本PR之后:

  • 老动态图调用_legacy_C_ops.xxx, 对应 C++中的op_function.cc
  • 中间态兼容老动态图,也调用_legacy_C_ops.xxx, 但对应的C++代码是eager_legacy_op_function.cc
  • 最终态,调用_C_ops.xxx,对应C++代码是eager_op_function.cc.cc

此外,后续还计划对调用_legacy_C_ops的PR加approve拦截。原则上避免新的_legacy_C_ops调用。

@paddle-bot
Copy link

paddle-bot bot commented Aug 22, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

JiabinYang
JiabinYang previously approved these changes Aug 25, 2022
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenwhql
chenwhql previously approved these changes Aug 25, 2022
@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Aug 25, 2022

LGTM for change paddle_build.bat

@luotao1
Copy link
Contributor

luotao1 commented Aug 25, 2022

@jeff41404 讨论后

XiaoguangHu01
XiaoguangHu01 previously approved these changes Aug 25, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea previously approved these changes Aug 25, 2022
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 previously approved these changes Aug 26, 2022
@wanghuancoder wanghuancoder changed the title [Eager] delete final state pre name [Eager] delete final state pre-name Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants